guillaumecle commented on code in PR #17274:
URL: https://github.com/apache/beam/pull/17274#discussion_r927992928
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -112,6 +116,20 @@ public String specification() {
}
public static JavaVersion forSpecification(String specification) {
+ for (JavaVersion ver : JavaVersion.values()) {
+ if (ver.specification.equals(specification)) {
+ return ver;
+ }
+ }
+ JavaVersion fallback = java11;
Review Comment:
one last question is what to do for the middle point, for now I using the
higher version (e.g.: use 17 when invoked from 14)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
