kennknowles commented on code in PR #22289:
URL: https://github.com/apache/beam/pull/22289#discussion_r928358362
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/RowWriterFactory.java:
##########
@@ -135,10 +136,12 @@ BigQueryRowWriter<ElementT> createRowWriter(String
tempFilePrefix, DestinationT
throw new IllegalStateException(
"createRowWriter called when schemaFactory is null; forgot to call
prepare()?");
}
+ @SuppressWarnings({
Review Comment:
`SerializableFunction` is parametric in input type and output type, it
doesn't need to change. What I'm not clear on is whether it is safe to make
`schemaFactory` have type `SerializableFunction<TableSchema, @Nullable
Schema>`. I don't recall if that causes problems because there are places that
do not properly check its return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
