egalpin commented on code in PR #22216:
URL: https://github.com/apache/beam/pull/22216#discussion_r929263881
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubCoderProviderRegistrar.java:
##########
@@ -37,6 +37,7 @@ public List<CoderProvider> getCoderProviders() {
TypeDescriptor.of(PubsubMessage.class),
PubsubMessageWithMessageIdCoder.of()),
CoderProviders.forCoder(
TypeDescriptor.of(PubsubMessage.class),
- PubsubMessageWithAttributesAndMessageIdCoder.of()));
+ PubsubMessageWithAttributesAndMessageIdCoder.of()),
+ CoderProviders.forCoder(TypeDescriptor.of(PubsubMessage.class),
PubsubMessageCoder.of()));
Review Comment:
moved this code to be the last in the registrar (rather than first),
otherwise there are failures in the tests. @johnjcasey Do you have any further
info on coder registrars and how a coder is resolved when multiple coders are
registered for the same class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
