lnogueir commented on code in PR #22306:
URL: https://github.com/apache/beam/pull/22306#discussion_r930129583
##########
sdks/go/pkg/beam/io/fhirio/common.go:
##########
@@ -73,8 +74,8 @@ type operationResults struct {
}
type fhirStoreClient interface {
- readResource(resourcePath string) (*http.Response, error)
- executeBundle(storePath string, bundle []byte) (*http.Response, error)
+ readResource(resourcePath []byte) (*http.Response, error)
+ executeBundle(storePath string, bundle string) (*http.Response, error)
Review Comment:
So that they match the input/output PCollection types of the transforms we
integrate with, like `textio` and `pubsubio`. Otherwise, the user will have to
make this conversion themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
