bamnet commented on a change in pull request #12061:
URL: https://github.com/apache/beam/pull/12061#discussion_r444481248
##########
File path: sdks/go/pkg/beam/io/bigqueryio/bigquery.go
##########
@@ -90,21 +90,27 @@ func Read(s beam.Scope, project, table string, t
reflect.Type) beam.PCollection
// TODO(herohde) 7/13/2017: using * is probably too inefficient. We
could infer
// a focused query from the type.
- return query(s, project, fmt.Sprintf("SELECT * from [%v]", table), t)
+ return query(s, project, fmt.Sprintf("SELECT * from [%v]", table), t,
nil)
+}
+
+// QueryOptions represents additional options for executing a query.
+type QueryOptions struct {
Review comment:
Done.
I agree, this is a cleaner design. I couldn't think of the phrase "variadic
list of functional options" to save my life.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
