youngoli commented on pull request #12059: URL: https://github.com/apache/beam/pull/12059#issuecomment-648449493
> If we were to get rid of the coderx package, I'd rather the coders move to the main beam package or similar, since they're invoked in inferCoders IIRC? My only objection is that we'd likely want to use those coders in packages further down in the SDK, but importing `beam` from those is a common cause of import cycles from my experience, so I'd prefer putting it in a subpackage instead (and we could always forward it to `beam` if we really want). I think having something like `graph/coder/custom` would be better. It's consolidated in the same directory tree as the builtin coders, but clearly separate since its in a subdirectory, and the package name is still clear (ex. `custom.NewIntCoder()`). Agreed with everything else, including waiting until a major version update before going through with this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
