emkornfield commented on a change in pull request #12070:
URL: https://github.com/apache/beam/pull/12070#discussion_r444641710
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -153,6 +156,17 @@ public String toString() {
@Experimental(Kind.SOURCE_SINK)
public static class BigQueryStorageStreamReader<T> extends
BoundedSource.BoundedReader<T> {
+ private final Counter streamingResponseCount =
+ Metrics.counter(
+ BigQueryStorageStreamReader.class,
"bq_storage_read_streaming_response_count");
+ private final Counter streamingResponseTotalLatencyMs =
+ Metrics.counter(
Review comment:
maybe
[distribution](https://beam.apache.org/releases/javadoc/2.0.0/org/apache/beam/sdk/metrics/Distribution.html)
for time base metrics?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
