mosche commented on code in PR #22485:
URL: https://github.com/apache/beam/pull/22485#discussion_r935697612
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java:
##########
@@ -407,13 +406,9 @@ public void testReplaceAll() {
new PipelineVisitor.Defaults() {
@Override
public CompositeBehavior enterCompositeTransform(Node node) {
- if (!node.isRootNode()) {
- assertThat(
- node.getTransform().getClass(),
- not(
- anyOf(
- Matchers.equalTo(GenerateSequence.class),
- Matchers.equalTo(Create.Values.class))));
+ String fullName = node.getFullName();
+ if (fullName.equals("unbounded") || fullName.equals("bounded")) {
+ assertThat(node.getTransform(),
Matchers.instanceOf(EmptyFlatten.class));
Review Comment:
Rather than checking what the transform class after applying the replacement
should not be (which was always the case anyways), this asserts that the
resulting transform is an instance of the expected class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
