lukecwik commented on code in PR #22373:
URL: https://github.com/apache/beam/pull/22373#discussion_r938015066
##########
sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/ReadFromPulsarDoFn.java:
##########
@@ -207,7 +189,7 @@ public OffsetRangeTracker restrictionTracker(
}
PulsarLatestOffsetEstimator offsetEstimator =
- new PulsarLatestOffsetEstimator(this.admin, pulsarSource.getTopic());
+ new PulsarLatestOffsetEstimator(null /*this.admin*/,
pulsarSource.getTopic());
Review Comment:
passing in `null` here will cause an NPE when we try to access the `client`
within the `PulsarLatestOffsetEstimator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
