dpcollins-google commented on code in PR #22612: URL: https://github.com/apache/beam/pull/22612#discussion_r939774784
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/UnboundedReaderImpl.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.pubsublite.internal; + +import static org.apache.beam.sdk.io.gcp.pubsublite.internal.ApiServices.asCloseable; +import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument; +import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkState; + +import com.google.api.core.ApiService.State; +import com.google.cloud.pubsublite.Offset; +import com.google.cloud.pubsublite.proto.SequencedMessage; +import com.google.protobuf.util.Timestamps; +import java.io.IOException; +import java.util.NoSuchElementException; +import java.util.Optional; +import java.util.concurrent.TimeUnit; +import org.apache.beam.sdk.io.UnboundedSource; +import org.apache.beam.sdk.io.UnboundedSource.UnboundedReader; +import org.apache.beam.sdk.transforms.windowing.BoundedWindow; +import org.joda.time.Instant; + +public class UnboundedReaderImpl extends UnboundedReader<SequencedMessage> { + + private final UnboundedSource<SequencedMessage, CheckpointMarkImpl> source; + private final MemoryBufferedSubscriber subscriber; + private final TopicBacklogReader backlogReader; + private final BlockingCommitter committer; + + private Offset fetchOffset; + private Optional<Instant> lastMessageTimestamp = Optional.empty(); + private boolean advanced = false; + + UnboundedReaderImpl( + UnboundedSource<SequencedMessage, CheckpointMarkImpl> source, + MemoryBufferedSubscriber subscriber, + TopicBacklogReader backlogReader, + BlockingCommitter committer, + Offset initialOffset) { + checkArgument(initialOffset.equals(subscriber.fetchOffset())); + this.source = source; + this.subscriber = subscriber; + this.backlogReader = backlogReader; + this.committer = committer; + this.fetchOffset = initialOffset; + } + + @Override + public SequencedMessage getCurrent() throws NoSuchElementException { + if (!advanced) { + throw new NoSuchElementException(); + } + return subscriber.peek().get(); + } + + @Override + public Instant getCurrentTimestamp() throws NoSuchElementException { + return getTimestamp(getCurrent()); + } + + private static Instant getTimestamp(SequencedMessage message) { + return Instant.ofEpochMilli(Timestamps.toMillis(message.getPublishTime())); + } + + @Override + public void close() throws IOException { + try (AutoCloseable c1 = backlogReader; + AutoCloseable c2 = committer; + AutoCloseable c3 = asCloseable(subscriber)) { + } catch (Exception e) { + throw new IOException(e); + } + } + + @Override + public boolean start() throws IOException { + try { + subscriber.startAsync().awaitRunning(1, TimeUnit.MINUTES); + } catch (Exception e) { + throw new IOException(e); + } + return advance(); Review Comment: This is the first line of advance(), so this check is already made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
