nielm commented on a change in pull request #12010:
URL: https://github.com/apache/beam/pull/12010#discussion_r445045365
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -1423,18 +1438,46 @@ public void processElement(ProcessContext c) {
}
@Setup
- public void setup() throws Exception {
- // set up non-serializable values here.
- spannerAccessor = SpannerAccessor.create(spannerConfig);
+ public void setup() {
+ spannerAccessor = spannerAccessors.get(spannerConfig);
+ if (spannerAccessor == null) {
+ synchronized (spannerAccessors) {
Review comment:
as above, moved refcounting into SpannerAccessor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
