mosche commented on code in PR #22620:
URL: https://github.com/apache/beam/pull/22620#discussion_r942514727
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/testing/TestStreamTest.java:
##########
@@ -105,6 +105,9 @@ public void testLateDataAccumulating() {
.advanceWatermarkTo(instant.plus(Duration.standardMinutes(6)))
// These elements are late but within the allowed lateness
.addElements(TimestampedValue.of(4L, instant),
TimestampedValue.of(5L, instant))
+ .advanceWatermarkTo(instant.plus(Duration.standardMinutes(10)))
Review Comment:
@kennknowles Maybe you could answer this? I'm wondering if this is an issue
of the Spark streaming runner (and how this is handled by other runners) or if
it's a lack of my own understanding.
> Without advancing the watermark once more the (lower) input watermark
remains at 6 mins, but data in [0,5 min) won't be considered late until it
passes 10 mins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
