TheNeuralBit commented on code in PR #22616: URL: https://github.com/apache/beam/pull/22616#discussion_r942830917
########## sdks/python/apache_beam/dataframe/io.py: ########## @@ -58,6 +58,17 @@ _DEFAULT_BYTES_CHUNKSIZE = 1 << 20 +@frame_base.with_docs_from(pd) Review Comment: Yeah, the new docstring here should be all of the user-facing documentation. _ReadGbq doesn't need to have a docstring since it's a private implementation detail (it could still have one to document its purpose, but this is for Beam devs, not for users). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
