johnjcasey commented on code in PR #22738:
URL: https://github.com/apache/beam/pull/22738#discussion_r947165913
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/SchemaUtil.java:
##########
@@ -313,11 +311,11 @@ private static <InputT, BaseT> ResultSetFieldExtractor
createLogicalTypeExtracto
/** Convert SQL date type to Beam DateTime. */
private static ResultSetFieldExtractor createDateExtractor() {
return (rs, i) -> {
- Date date = rs.getDate(i,
Calendar.getInstance(TimeZone.getTimeZone(ZoneOffset.UTC)));
+ java.time.LocalDate date = rs.getObject(i, java.time.LocalDate.class);
Review Comment:
Gross, but understandable. Can you add a TODO here linked to that issue to
clean this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
