ryanthompson591 commented on code in PR #22730:
URL: https://github.com/apache/beam/pull/22730#discussion_r947283042
##########
sdks/python/apache_beam/runners/portability/local_job_service.py:
##########
@@ -184,7 +185,11 @@ def __init__(
control_address,
provision_info,
worker_id=None):
- self._worker_command_line = worker_command_line
+ if sys.platform == 'win32' and isinstance(worker_command_line, bytes):
+ # Fix subprocess.Popen not support bytes args
+ self._worker_command_line = worker_command_line.decode()
Review Comment:
is it possible that decoding will work both on windows and other systems? If
so then maybe just always call decode.
##########
sdks/python/apache_beam/runners/portability/local_job_service.py:
##########
@@ -184,7 +185,11 @@ def __init__(
control_address,
provision_info,
worker_id=None):
- self._worker_command_line = worker_command_line
+ if sys.platform == 'win32' and isinstance(worker_command_line, bytes):
+ # Fix subprocess.Popen not support bytes args
Review Comment:
fix this comment, it is unclear if it is a todo or this saying that this
section is to fix this unwanted behavior.
I suggest referencing the issue here too if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
