damccorm commented on code in PR #22761:
URL: https://github.com/apache/beam/pull/22761#discussion_r948406719
##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -374,6 +390,8 @@ func New(fn reflectx.Func) (*Fn, error) {
kind = FnWindow
case t == typex.BundleFinalizationType:
kind = FnBundleFinalization
+ case t == state.ProviderType:
Review Comment:
I'd probably vote we leave it as is unless there's a reason to switch - the
[typex package generally only exports types for structs it
defines](https://github.com/apache/beam/blob/48bad7d966a583055669850eb9fb558782f636a8/sdks/go/pkg/beam/core/typex/special.go#L45)
and IMO it makes sense to stay it in the state package to keep consistent with
that. I don't feel super strongly though (@lostluck might have opinions too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
