vchunikhin commented on code in PR #22722:
URL: https://github.com/apache/beam/pull/22722#discussion_r949046669
##########
.github/workflows/playground_deploy_examples.yml:
##########
@@ -133,6 +133,8 @@ jobs:
K8S_SERVER_ADDRESS=$(kubectl get svc -n $K8S_NAMESPACE -l
"app=service-python" -o
jsonpath='{.items[0].status.loadBalancer.ingress[0].ip}')
BEAM_ROOT_DIR="../../"
BEAM_EXAMPLE_CATEGORIES="../../playground/categories.yaml"
+ GOOGLE_CLOUD_PROJECT_VALUE=${{ secrets.GCP_PLAYGROUND_PROJECT_ID
}}
Review Comment:
This env variable needs to connect to the Cloud Datastore
##########
playground/backend/containers/go/Dockerfile:
##########
@@ -16,27 +16,28 @@
# limitations under the License.
###############################################################################
#Dokerfile to set up the Beam Go SDK
-ARG BASE_IMAGE=golang:1.16-bullseye
+ARG BASE_IMAGE=golang:1.18-bullseye
Review Comment:
Since BEAM version was updated to the latest version, we have to update our
golang version
##########
learning/katas/java/Core
Transforms/CoGroupByKey/CoGroupByKey/src/org/apache/beam/learning/katas/coretransforms/cogroupbykey/Task.java:
##########
@@ -19,7 +19,7 @@
package org.apache.beam.learning.katas.coretransforms.cogroupbykey;
// beam-playground:
-// name: GroupByKey
+// name: JoinPCollections
Review Comment:
We forbid examples with the same names for one SDK. An example name should
be unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
