lukecwik commented on code in PR #22645:
URL: https://github.com/apache/beam/pull/22645#discussion_r949409598
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java:
##########
@@ -996,10 +1001,18 @@ public void finishBundle(FinishBundleContext c) throws
Exception {
c.output(result.getValue(), result.getKey(),
result.getValue().getWindow());
}
} finally {
- deferredOutput = null;
- closeFutures = null;
+ deferredOutput.clear();
+ closeFutures.clear();
}
}
+
+ // Ensure that transient fields are initialized.
Review Comment:
And reverted back because spot bugs prefers it during deserialization so
that we can ensure that the fields are set since spotbugs doesn't know about
the DoFn lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
