lukecwik commented on PR #22780: URL: https://github.com/apache/beam/pull/22780#issuecomment-1219941617
> Nice! Just curious was this noticable in a benchmark/profile? It certainly seems like it will help especially with the many encodes per windmill output The swap to ByteStringOutputStream caused a test pipeline to flake with OOMs because of a lot partially filled buffers so this removed that issue. The original swap to use ByteStringOutputStream had noticeable improvements for encoding small things with anywhere from 3 to 10x improvement (https://github.com/apache/beam/pull/22345) but in the big picture of things it lead to about a 0.5% CPU usage reduction in bigshuffle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
