damccorm commented on code in PR #22796:
URL: https://github.com/apache/beam/pull/22796#discussion_r950266281
##########
sdks/go/pkg/beam/core/graph/fn.go:
##########
@@ -1272,9 +1272,8 @@ func validateState(fn *DoFn, numIn mainInputs) error {
err := errors.Errorf("Duplicate state key %v",
k)
return errors.SetTopLevelMsgf(err, "Duplicate
state key %v used by %v and %v. Ensure that state keys are"+
"unique per DoFn", k, orig, s)
- } else {
- stateKeys[k] = s
}
+ stateKeys[k] = s
Review Comment:
There's another similar violation on line 1281 that needs fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
