apilloud commented on code in PR #22801: URL: https://github.com/apache/beam/pull/22801#discussion_r951737940
########## sdks/python/apache_beam/testing/benchmarks/nexmark/README.md: ########## @@ -23,22 +23,28 @@ For batch mode, a file needs to be generated first by running java suite and writing events to a file. Review Comment: I left it because I didn't think it was necessary to duplicate it for both variants. ########## sdks/python/apache_beam/testing/benchmarks/nexmark/README.md: ########## @@ -23,22 +23,28 @@ For batch mode, a file needs to be generated first by running java suite and writing events to a file. -```shell script -./gradlew :sdks:java:testing:nexmark:run \ - -Pnexmark.runner=":runners:direct-java" - -Pnexmark.args=" --query=1 --runner=DirectRunner --streaming=false --suite=SMOKE --numEvents=100000 --manageResources=false --monitorJobs=true --enforceEncodability=true --enforceImmutability=true --generateEventFilePathPrefix=YOUR_FILE_PREFIX" -``` - ### Direct Runner ```shell script -python nexmark_launcher.py --query 5 --num_events 10000 --runner DirectRunner --input PATH_TO_INPUT_FILE +./gradlew :sdks:java:testing:nexmark:run \ + -Pnexmark.runner=":runners:direct-java" \ + -Pnexmark.args="--query=0 --runner=DirectRunner --numEvents=100000 --manageResources=false --monitorJobs=true --enforceEncodability=true --enforceImmutability=true --generateEventFilePathPrefix=/tmp/eventfile" + +./gradlew :sdks:python:apache_beam:testing:benchmarks:nexmark:run \ + -Pnexmark.args="--query=0 --num_events=100000 --runner=DirectRunner --input=/tmp/eventfile\*" Review Comment: I agree. I didn't see an easy way to do it so I'm leaving it as two commands for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
