iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445543215
##########
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
+ .put("numResults", "integer")
+ .build();
+ if (options.getExportSummaryToBigQuery()) {
savePerfsToBigQuery(
BigQueryResultsPublisher.create(options.getBigQueryDataset(),
schema),
options,
actual,
start);
}
+
+ if (options.getExportSummaryToInfluxDB()) {
+ final long timestamp = start.getMillis() / 1000; // seconds
Review comment:
Yes you guys are right seconds is ok for the timestamps but ms are good
for the benchmark results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
