ZijieSong946 commented on a change in pull request #12054: URL: https://github.com/apache/beam/pull/12054#discussion_r445588691
########## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ########## @@ -2457,6 +2458,256 @@ public void testDateFromUnixInt64() { pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES)); } + ///////////////////////////////////////////////////////////////////////////// + // TIME type tests + ///////////////////////////////////////////////////////////////////////////// + + @Test + public void testTimeLiteral() { + String sql = "SELECT TIME '15:30:00'"; Review comment: It seems that TIME literal only works with millisecond precision. - TIME '15:30:00.123456' will be converted to '15:30:00.123' - TIME '15:30:00.123456789' seems invalid for TIME literal function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org