TheNeuralBit commented on code in PR #22834:
URL: https://github.com/apache/beam/pull/22834#discussion_r954299525
##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -228,6 +228,23 @@ def test_windowed_batches(self):
7, # elements in [30, 47)
]))
+ def test_global_batch_timestamps(self):
+ # Assumes a single bundle, in order...
Review Comment:
Since you erase the values with `len` and `equal_to` is order-agnostic,
doesn't this not actually care about order?
```suggestion
# Assumes a single bundle
```
##########
sdks/python/apache_beam/transforms/window.py:
##########
@@ -376,6 +376,10 @@ def windowed_value(
# type: (...) -> WindowedValue
return WindowedValue(value, timestamp, (GlobalWindow(), ), pane_info)
+ @classmethod
+ def windowed_value_at_end_of_window(cls, value):
+ return cls.windowed_value(value, GlobalWindow().max_timestamp())
Review Comment:
should this be `end` instead of `max_timestamp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
