eantyshev commented on code in PR #22556: URL: https://github.com/apache/beam/pull/22556#discussion_r957522210
########## .github/workflows/tour_of_beam_backend.yml: ########## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# To learn more about GitHub Actions in Apache Beam check the CI.md + +name: Go tests + +on: + push: + branches: ['master', 'release-*'] + tags: 'v*' + pull_request: + branches: ['master', 'release-*'] + tags: 'v*' + paths: ['learning/tour-of-beam/backend/**'] + +jobs: + checks: + runs-on: ubuntu-latest + defaults: + run: + working-directory: ./learning/tour-of-beam/backend + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-go@v3 + with: + go-version: '1.16' + - name: Run fmt + run: | + go fmt ./... + git diff-index --quiet HEAD || (echo "Run go fmt before checking in changes" && exit 1) + + - name: Run vet + run: go vet ./... + + - name: Run test + run: go test -v ./... + + - name: golangci-lint + uses: golangci/golangci-lint-action@v3 + with: + version: v1.49.0 + working-directory: learning/tour-of-beam/backend + skip-cache: true Review Comment: Strictly speaking there's none :) Just not very familiar with its internals. Probably, we won't get much from it if we start from 0 pre-existing linter issues And probably an insignificant CI timing increase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
