yeandy commented on code in PR #22974:
URL: https://github.com/apache/beam/pull/22974#discussion_r959995715
##########
.pre-commit-config.yaml:
##########
@@ -11,7 +11,7 @@
# limitations under the License.
default_language_version:
- python: python3.7
+ python: python3
Review Comment:
What, if any, is the effect of this change?
##########
sdks/python/tox.ini:
##########
@@ -266,6 +266,7 @@ commands =
{toxinidir}/scripts/run_pytest.sh {envname} 'apache_beam/dataframe'
[testenv:py{37,38,39}-pytorch-{19,110}]
+# If updating supported pytorch versions, be sure to update them in the
ModelHandler docstrings in pytorch_inference.py as well
Review Comment:
```suggestion
# When updating the PyTorch versions used for testing, be sure to update the
documentation in the docstrings of the PytorchModelHandlerTensor and
PytorchModelHandlerKeyedTensor classes found in pytorch_inference.py
```
##########
sdks/python/apache_beam/ml/inference/pytorch_inference.py:
##########
@@ -74,6 +74,9 @@ def __init__(
pcoll | RunInference(PytorchModelHandlerTensor(state_dict_path="my_uri"))
+ Supported Versions:
+ PyTorch 1.9 and 1.10 are currently supported for Python 3.7, 3.8, and 3.9
+
Review Comment:
Consider moving this below the `Args` section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
