[GitHub] [beam] nausharipov commented on a diff in pull request #22794: [Tour of Beam]: Welcome Screen frontend layout

[GitBox]

nausharipov commented on code in PR #22794:
URL: https://github.com/apache/beam/pull/22794#discussion_r960393854


##########
learning/tour-of-beam/frontend/lib/pages/welcome/screen.dart:
##########
@@ -65,15 +65,23 @@ class _SdkSelection extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return ColoredBox(
+    return Container(
+      constraints: BoxConstraints(
+        minHeight: MediaQuery.of(context).size.height -

Review Comment:
   <img width="592" alt="Screen Shot 2022-09-01 at 14 53 48" 
src="https://user-images.githubusercontent.com/31556582/187874174-5d06b4e7-21d6-4318-9b56-c53eb7ed4f45.png";>
   <img width="1428" alt="Screen Shot 2022-09-01 at 14 54 11" 
src="https://user-images.githubusercontent.com/31556582/187874236-598644bf-4816-4e51-ac74-7947399a7dbf.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org