udim commented on a change in pull request #12088: URL: https://github.com/apache/beam/pull/12088#discussion_r445925136
########## File path: sdks/python/apache_beam/transforms/util.py ########## @@ -741,6 +741,7 @@ def WithKeys(pcoll, k): @experimental() @typehints.with_input_types(Tuple[K, V]) [email protected]_output_types(Tuple[K, List[V]]) Review comment: The test passes because 2 batches/elements are output. And I was running the test via pytest as usual. I don't follow the state api reasoning, and this is not documented in GroupIntoBatches. If you get a different result in DirectRunner vs DataflowRunner, it's a bug. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
