Abacn commented on PR #23027: URL: https://github.com/apache/beam/pull/23027#issuecomment-1237522922
> Just curious, can the job end with another terminal state other than `DONE` or `FAILED`? e.g., if executed in a runner that supports cancellation. > > If so, we could expect for `DONE` explicitly, instead of checking for not `FAILED`. Yes you are right, cancel is missed in this assertion. I thought about if assert DONE or assert not FAILED. There exists some streaming tests that set to cancel the pipeline after certain time (because streaming pipelines generally does not DONE by themself); For simplicity I add same assertions for all performance tests. Yes if we investigate each tests, including cancel as failure sounds more accurate; even more accurate the test should be marked as Aborted because a cancellation is initiated outside of the pipeline execution and done by runner (e.g. someone cancelled the pipeline at Dataflow). I just did not go this far. Assert not FAIL should suffice for the testing of Beam SDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
