nbali commented on code in PR #22953:
URL: https://github.com/apache/beam/pull/22953#discussion_r964255247
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java:
##########
@@ -116,16 +123,6 @@ public void testInGlobalWindowBatchSizeCount() {
PAssert.that("Incorrect batch size in one or more elements", collection)
.satisfies(
new SerializableFunction<Iterable<KV<String, Iterable<String>>>,
Void>() {
-
- private boolean checkBatchSizes(Iterable<KV<String,
Iterable<String>>> listToCheck) {
- for (KV<String, Iterable<String>> element : listToCheck) {
- if (Iterables.size(element.getValue()) != BATCH_SIZE) {
Review Comment:
I did notice that it's `!=` and not `>` here, but the test is still valid
with `>` (we have 10 elements, and 5 batch size, so it can't be anything but 5,
and we check the batch count at the end with `EVEN_NUM_ELEMENTS / BATCH_SIZE`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
