kamilwu commented on a change in pull request #12102:
URL: https://github.com/apache/beam/pull/12102#discussion_r446229462



##########
File path: 
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -255,7 +255,11 @@ private static String produceMeasurement(
     schemaResults.put("timestamp", timestamp);
     schemaResults.put("runner", runner);
     schemaResults.put("measurement", measurement);
-    schemaResults.put("runtimeMs", runtimeMs);
+    schemaResults.put(
+        "runtimeMs",

Review comment:
       We should do the same for `numResults`. Now the schema that is being 
created is:
   ```
   fieldKey   fieldType
   --------   ---------
   numResults float
   runtimeMs  integer
   ```
   And we need `numResults` as an integer too. I'm sorry I didn't notice that 
earlier. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to