lukecwik commented on code in PR #23046:
URL: https://github.com/apache/beam/pull/23046#discussion_r966392922
##########
sdks/python/apache_beam/runners/worker/sdk_worker.py:
##########
@@ -1149,7 +1149,7 @@ def blocking_get(
return self._lazy_iterator(state_key, coder)
# Cache lookup
cache_state_key = self._convert_to_cache_key(state_key)
- cached_value = self._state_cache.get(cache_state_key, cache_token)
+ cached_value = self._state_cache.peek((cache_state_key, cache_token))
Review Comment:
I swapped the API to use a single key field since the internal
implementation of the cache shouldn't care. Now the clients will pass in a
tuple that represents the key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
