tvalentyn commented on code in PR #22999:
URL: https://github.com/apache/beam/pull/22999#discussion_r966405179
##########
sdks/python/apache_beam/runners/portability/local_job_service_main.py:
##########
@@ -129,6 +131,9 @@ def run(argv):
print('Server started at port', port)
return
+ if options.default_pickler:
+ pickler.set_library(options.default_pickler)
Review Comment:
> I wasn't aware that there was such a pipeline option
It's used for example here:
https://github.com/apache/beam/blob/f0cd27596e3a59d6ee013ee2db232d24f46ad70a/sdks/python/apache_beam/runners/worker/sdk_worker_main.py#L103
> it doesn't seem possible to set on a per-pipeline basis
I wonder if this is the same as: https://github.com/apache/beam/issues/21615
> If you feel it's worth changing the name, we should do so before the next
release
I think it would be worthwhile. Would someone working on xlang have
bandwidth look into that?
If we are making cloudpickle default, I would consider tightening the bounds
on cloudpickle to
cloudpickle>=2.2.0,<2.3.0 , and bumping that bound every beam release until
we decide to vendor the library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
