yeandy commented on PR #22928: URL: https://github.com/apache/beam/pull/22928#issuecomment-1241226921
Thanks for the info, and contributing to Beam! In general, you're doing the right steps. You did `take-issue` on the original issue, and also noted the issue number in the title. I didn't realize at first; hence my question about context. I would be helpful to link the issue in the description of this PR 😄 The next steps would to address any PreCommit checks that are failing. You have a few  You can see what is wrong if you click under Details. We have a bot to automatically assign reviewers. (This time, it was me). You can also manually choose a reviewer if you know someone in particular you want to review. However, @AnandInguva and I are actually working on a bunch of changes (https://github.com/apache/beam/pull/22995) in preparation to support Python 3.10. While working, I had identified the need to address the issue (https://github.com/apache/beam/issues/20982) that you originally took, and made a PR (https://github.com/AnandInguva/beam/pull/4) already. I guess we accidentally started working on this at the same time 😅 I'd say you're welcome to continue work on this PR (and also take inspiration from what I've done). Depending on how fast/slow our 3.10 work takes (I can update you via this PR), you may be able to make this fix into master before us? But I also don't want there to be redundant work being done. @AnandInguva How do you think we should approach this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
