dpcollins-google commented on PR #22762: URL: https://github.com/apache/beam/pull/22762#issuecomment-1242586590
> This is somewhat beyond my understanding. > > I'd prefer to not use a depreciated method if possible, but for the release I believe this is ok. > > Was there a reason you can't simply add a finalize() method to CheckpointMarkImpl directly, avoiding this indirection? Yes, we only want to close when no checkpointMarks exist that are using this, not when each goes out of scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
