ryanthompson591 commented on issue #21721: URL: https://github.com/apache/beam/issues/21721#issuecomment-1243885273
It makes the most sense to me to put the namespace on the base model handler. This puts the user in full control. Some outstanding questions would be what would happen with wrapper model handlers - like KeyedModelHandler.' I think the obvious thing would be to make some sort of default behavior that wrappers should do. Something like passing the namespace overrides/prefixes to the wrapped model handlers. I'm not sure if the base model handler should prefix name spaces or not. Something like: handler = MyModelHandler(name_space_override='my_defined_namespace') -> namespace is set to my_defined_namespace or handler = SklearnModelHandler(name_space_prefix='some_prefix_') -> namespace is set to some_prefix_sklearn_namespace Anand, I think there are a few options how to do this. What do you think about outlining them in a short doc, and then we can pick one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
