kw2542 commented on code in PR #22976:
URL: https://github.com/apache/beam/pull/22976#discussion_r968795390
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaTimerInternalsFactory.java:
##########
@@ -193,7 +201,7 @@ public Collection<KeyedTimerData<K>> removeReadyTimers() {
}
LOG.debug("Removed {} ready timers", readyTimers.size());
- if (readyTimers.size() == maxReadyTimersToProcessOnce
+ if (readyTimers.size() >= maxReadyTimersToProcessOnce
Review Comment:
This change may not be necessary since readyTimers size is incremented by
one per loop, but should be safe to update to `>=`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
