KevinGG commented on code in PR #23069:
URL: https://github.com/apache/beam/pull/23069#discussion_r970211842
##########
sdks/python/apache_beam/runners/interactive/pipeline_fragment.py:
##########
@@ -233,3 +234,9 @@ def visit_transform(self, transform_node):
v = PruneVisitor()
runner_pipeline.visit(v)
return runner_pipeline
+
+
+def should_skip_pruning(transform: AppliedPTransform):
+ return (
+ isinstance(transform.transform, TestStream) or
+ '_DataFrame_' in transform.full_label)
Review Comment:
I would recommend adding unittests with ib.collect for each Series
operation. In that case, we don't have to skip pruning prematurely.
The same also applies to the DeferredDataFrame operations. If applicable
(when a proper pruning is in-place, in the future add some unittest with
ib.collect (following the InteractiveDataFrameTest in this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
