yixiaoshen commented on code in PR #22966:
URL: https://github.com/apache/beam/pull/22966#discussion_r970236111
##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -196,6 +196,8 @@ task integrationTest(type: Test, dependsOn:
processTestResources) {
exclude '**/BigQueryIOStorageWriteIT.class'
exclude '**/BigQueryToTableIT.class'
exclude '**/BigQueryIOJsonTest.class'
+ // TODO Firestore IT test needs to run in a separate project from Datastore.
+ exclude '**/FirestoreV1IT.class'
Review Comment:
I have locally run FirestoreV1IT test against a different GCP project to
make sure the code behaves correctly. I'm currently working on another change
to enable this test, hopefully in the same GCP project by using a new Firestore
feature that's not launched yet but we can internally allowlist this test
project to use that. I expect to have that ready in a few days, but I don't
want it to block this PR because FirestoreV1IT has never run in the past
because it was incorrectly written and it's an unrelated problem from read_time
support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
