mosche commented on PR #22446: URL: https://github.com/apache/beam/pull/22446#issuecomment-1246960156
I agree, that leaves room for potential new confusion. Giving this a 2nd thought I suppose you're right and `SparkDatasetRunner` is the better name with less ambiguity ... nevertheless it's a rather technical name which i'd usually rather avoid. Regarding the rename or any other incompatible changes I'm personally fairly relaxed at this stage: - it's clearly marked as experimental and such changes are to be expected - the runner isn't optimised in any way yet, so there's little to no reason to use an experimental runner over a proven existing one (besides scalability issues that make me doubt a bit it would work well on decent sized datasets) - users typically don't (and probably shouldn't) interact with runner packages / classes (the metrics sink might be the only exception) - and last, in case it is used, changing the runner name is trivial enough... There could be a dummy runner with the old name that calls out to the new one and asks users to change their configuration .... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
