alexeyinkin commented on code in PR #23253:
URL: https://github.com/apache/beam/pull/23253#discussion_r971911648
##########
playground/frontend/lib/pages/embedded_playground/components/embedded_editor.dart:
##########
@@ -30,21 +27,17 @@ class EmbeddedEditor extends StatelessWidget {
@override
Widget build(BuildContext context) {
- final state = Provider.of<PlaygroundState>(context);
- final controller = state.snippetEditingController;
+ final controller = Provider.of<PlaygroundController>(context);
+ final snippetController = controller.snippetEditingController;
- if (controller == null) {
- return const LoadingIndicator(size: kLgLoadingIndicatorSize);
+ if (snippetController == null) {
+ return const LoadingIndicator();
Review Comment:
We had two sizes of the indicator: 40px and 50px.
I don't think it was a formal requirement for the two sizes. Can we go with
just one of them simplifying things for Apache to maintain after we are done?
(Given that I added them instead of an empty editor in the first place.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
