shanemhansen opened a new pull request, #23269: URL: https://github.com/apache/beam/pull/23269
jar Class-Path entries have a max line length which, when exceeded, will cause java to fail to start. See: https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html Use newline plus extra space to support large numbers of jar files. R: @robertwb FIXES: #23268 Tested: via[ standalone monkey-patched version of method (https://gist.github.com/shanemhansen/c7b7fa4a0b5cea7a000f090c4728b68b) and later via unit test below: ```bash tox -e py39 -- apache_beam/utils/subprocess_server_test.py ``` Also did some quick and dirty manual tests to ensure code path for generating jar was covered subprocess_server_test.py. Confirmed: - ' '.join(classpath) (previous impl) works for unit test - '\n '.join(classpath) (current impl) works for unit test - ' x'.join(classpath) fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
