alexeyinkin commented on code in PR #23253:
URL: https://github.com/apache/beam/pull/23253#discussion_r972731334
##########
playground/frontend/lib/modules/editor/components/share_dropdown/share_tabs_headers.dart:
##########
@@ -35,17 +35,19 @@ class ShareTabsHeaders extends StatelessWidget {
Widget build(BuildContext context) {
final appLocale = AppLocalizations.of(context)!;
- return Consumer<PlaygroundState>(builder: (context, state, child) {
- return SizedBox(
- width: _width,
- child: TabBar(
- controller: tabController,
- tabs: [
- Text(appLocale.link),
- Text(appLocale.embed),
- ],
- ),
- );
- });
+ return Consumer<PlaygroundController>(
+ builder: (context, controller, child) {
+ return SizedBox(
+ width: _width,
Review Comment:
This was only indented but not added. I would rather not add more
refactoring.
This PR focuses on establishing a more or less stable interface between the
two apps and the shared package. All the internals of the three will be
addressed later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
