KevinGG commented on code in PR #23271:
URL: https://github.com/apache/beam/pull/23271#discussion_r973421057
##########
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py:
##########
@@ -64,6 +92,30 @@ def __init__(self, cluster_metadata: ClusterMetadata) ->
None:
})
self._fs = gcsfilesystem.GCSFileSystem(PipelineOptions())
self._staging_directory = None
+ cache_dir = ie.current_env().options.cache_root
+ try:
+ assert cache_dir.startswith('gs://')
Review Comment:
You are absolutely right, assert should not be used to validate user input.
I'll change it to raise a ValueError.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
