lostluck commented on PR #23307: URL: https://github.com/apache/beam/pull/23307#issuecomment-1252652366
Change causes some of the regression tests to fail https://ci-beam.apache.org/job/beam_PreCommit_Go_Commit/12491/console I'm a bit indisposed this week due to a summit at work, but when I get a moment I'll see if I can't find what's going wrong with the expectations. The test is correct and required to pass, so the fix needs to be on the direct runner side too. `github.com/apache/beam/sdks/v2/go/test/regression` is the package to run against. It should run automatically against the direct runner for you to iterate against. You shouldn't need to comment "Retest this please" when you push changes, since the precommits run against the direct runner and are failing as a result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
