TheNeuralBit commented on a change in pull request #12090:
URL: https://github.com/apache/beam/pull/12090#discussion_r447119597
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonTableProvider.java
##########
@@ -54,125 +47,29 @@ public String getTableType() {
}
Review comment:
Yes my intention was that they should be the same. I'm not that
concerned about it being hard-coded for now. We're planning to replace this
class with a general-purpose "wrapper" that can adapt any
`SchemaCapableIOProvider` to the `TableProvider` interface, and I figured
`getTableType` would just call `SchemaCapableIOProvider#identifier`.
That work is tracked in BEAM-10337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
