zhangt-nhlab commented on PR #23075:
URL: https://github.com/apache/beam/pull/23075#issuecomment-1257337413

   > > First of all - thanks for your contribution!
   > > Before proceeding to review from my side, I'd like to know if there is a 
design doc or similar for this IO connector? It would be very helpful to 
understand the goals and the implementation of this connector in advance.
   > > Also, several notes that are worth to mention:
   > > 
   > > 1. Please, create a new github issue for this feature.
   > > 2. Please, avoid merging a `master` branch into your feature branch. Use 
`git rebase` instead.
   > > 3. Run `./gradlew :sdks:java:io:datalake:check` locally before pushing 
your changes to origin.
   > > 
   > > You can find a Beam contribution guide here: 
https://beam.apache.org/contribute/get-started-contributing/
   
   Thank you for your reply! I will make my changes, and create a new github 
issue later. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to