Abacn commented on code in PR #22930:
URL: https://github.com/apache/beam/pull/22930#discussion_r980198815
##########
website/www/site/data/capability_matrix.yaml:
##########
@@ -36,1463 +36,1463 @@ capability-matrix:
categories:
- description: What is being computed?
anchor: what
- color-y: "fff"
- color-yb: "f6f6f6"
- color-p: "f9f9f9"
- color-pb: "d8d8d8"
- color-n: "e1e0e0"
- color-nb: "bcbcbc"
+ color-y: 'fff'
Review Comment:
Is there a reason changing " -> '? They look redundant
##########
.gitignore:
##########
@@ -115,8 +115,11 @@ website/www/site/code_samples
website/www/site/_config_branch_repo.toml
website/www/yarn-error.log
!website/www/site/content
+.test-infra/validate-runner/src/main/js/apache-beam-testing-keys.json
# Node
+sdks/typescript/node_modules
+node_modules/**
Review Comment:
There are still multiple website dependency files in the repo root directory
e.g. `package-locks.json`, `package.json`, `yarn.lock`. Should organize it in
somewhere under `website` folder.
There is already a project root in "website/www/" , there is an `yarn.lock`
and `package.json` file there for the website dependency. (and
`website/www/node_modules` is already in .gitignore)
Or If it is necessary to create a different project to generete the
capability matrix, could move them into `website/generate_capability_matrix`
project or so.
May ask @pabloem which one of the choice is preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
