Abacn commented on code in PR #23014:
URL: https://github.com/apache/beam/pull/23014#discussion_r980409220
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -267,12 +269,24 @@ def typing_to_runner_api(self, type_: type) ->
schema_pb2.FieldType:
logical_type=schema_pb2.LogicalType(urn=PYTHON_ANY_URN),
nullable=True)
else:
- # TODO(bhulette): Add support for logical types that require arguments
- return schema_pb2.FieldType(
- logical_type=schema_pb2.LogicalType(
- urn=logical_type.urn(),
- representation=self.typing_to_runner_api(
- logical_type.representation_type())))
+ if logical_type.argument_type() is None:
+ return schema_pb2.FieldType(
+ logical_type=schema_pb2.LogicalType(
+ urn=logical_type.urn(),
+ representation=self.typing_to_runner_api(
+ logical_type.representation_type())))
+ else:
+ # TODO(bhulette,yathu): Complete support for logical types that require
+ # arguments.
Review Comment:
entered #23373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
