damccorm commented on code in PR #23349:
URL: https://github.com/apache/beam/pull/23349#discussion_r982523296
##########
learning/tour-of-beam/backend/internal/sdk.go:
##########
@@ -19,33 +19,52 @@ type Sdk string
const (
SDK_UNDEFINED Sdk = ""
- SDK_GO Sdk = "Go"
- SDK_PYTHON Sdk = "Python"
- SDK_JAVA Sdk = "Java"
- SDK_SCIO Sdk = "SCIO"
+ SDK_GO Sdk = "go"
+ SDK_PYTHON Sdk = "python"
+ SDK_JAVA Sdk = "java"
+ SDK_SCIO Sdk = "scio"
)
func (s Sdk) String() string {
return string(s)
}
-// Parse sdk from string names, f.e. "Java" -> Sdk.GO_JAVA
+func (s Sdk) Title() string {
+ switch s {
+ case SDK_GO:
+ return "Go"
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
